feat: changing the playback speed and volume with the mouse wheel / scroll (fixes #3388)#3661
feat: changing the playback speed and volume with the mouse wheel / scroll (fixes #3388)#3661W07L wants to merge 0 commit intocode-charity:masterfrom
Conversation
js&css/web-accessible/core.js
Outdated
| if (message.key.startsWith('shortcut_') || message.key === 'shortcuts_volume_wheel_ctrl') { | ||
| camelized_key = 'shortcuts'; | ||
| if (typeof ImprovedTube.shortcutsInit === 'function') { | ||
| ImprovedTube.shortcutsInit(); |
There was a problem hiding this comment.
shortcutsInit can be called when shortcuts change,
not required again for every shortcut pressed.
|
Thank you so much! @W07L Please check: #862 Glad you had a look at shortcuts.js #1565 ImprovedTube needs structure / feature discoverability #2251 #748 We have the functionality ( @Heinz14 @W07L ) (Yet it is popular and should have had a quick preset option accessible with one or a few clicks.) |
|
hi @W07L
Are you sure? Doesn't look finished to me! Will you finish it? (Consider:
) Thanks! |
Hello @ImprovedTube, sorry i totally forget about that. So i only have to make change in menu/skeleton-parts/shortcuts.js ? |
2 participants
Summary
I have work on this feature request #3388. I have add the possibility to change speedback speed and volume with Mouse wheel/scroll + Shift/Ctrl/Alt
Both of them work by toggle the option and set the shotcuts. It take effect when the mouse is on the video or the video is on fullscreen
Change
Test
I have on Microsoft Edge, Google Chrome and Firefox and it work on all of them.